luismarques added a comment. Regarding D74399 <https://reviews.llvm.org/D74399>, cmake on a fedora RISC-V host still detects a generic triple:
-- LLVM host triple: riscv64-unknown-linux-gnu -- LLVM default target triple: riscv64-unknown-linux-gnu as opposed to the `gcc -dumpmachine` triple of `riscv64-redhat-linux` (with the vendor and no `-gnu` suffix), needed for a working toolchain. (I don't know if that cmake behaviour is uncommon or not). Are you saying that it's fine for D74399 <https://reviews.llvm.org/D74399> to remain because of that, or does your argument also imply that D74399 <https://reviews.llvm.org/D74399> should be reverted? Would the answer change if cmake started detecting the "proper" triple? (and what would the deprecation path for that be, if any?). ================ Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2108-2113 + "x86_64-linux-gnu", "x86_64-unknown-linux-gnu", + "x86_64-pc-linux-gnu", "x86_64-redhat-linux6E", + "x86_64-redhat-linux", "x86_64-manbo-linux-gnu", + "x86_64-linux-gnu", "x86_64-slackware-linux", + "x86_64-unknown-linux", "x86_64-amazon-linux", + "x86_64-linux-android"}; ---------------- Ugh, these lines with multiple entries make mentally parsing the diff rather annoying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109727/new/ https://reviews.llvm.org/D109727 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
