MaskRay added a comment. In D109727#3003498 <https://reviews.llvm.org/D109727#3003498>, @luismarques wrote:
> Regarding D74399 <https://reviews.llvm.org/D74399>, cmake on a fedora RISC-V > host still detects a generic triple: > > -- LLVM host triple: riscv64-unknown-linux-gnu > -- LLVM default target triple: riscv64-unknown-linux-gnu > > as opposed to the `gcc -dumpmachine` triple of `riscv64-redhat-linux` (with > the vendor and no `-gnu` suffix), needed for a working toolchain. (I don't > know if that cmake behaviour is uncommon or not). This is due to issues in config.guess. D109837 <https://reviews.llvm.org/D109837> will fix it. > Are you saying that it's fine for D74399 <https://reviews.llvm.org/D74399> to > remain because of that, or does your argument also imply that D74399 > <https://reviews.llvm.org/D74399> should be reverted? Would the answer change > if cmake started detecting the "proper" triple? (and what would the > deprecation path for that be, if any?). The code change of D74399 <https://reviews.llvm.org/D74399> should be reverted. The test can stay, but I won't think we need too many riscv64-$distro-linux-gnu tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109727/new/ https://reviews.llvm.org/D109727 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
