jdoerfert added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1118 + llvm::GlobalValue::WeakAnyLinkage, + llvm::ConstantInt::get(CGM.Int8Ty, Mode ? 0x2 : 0x1), + Twine(Name, "_exec_mode")); ---------------- The magic constants need to go into OpenMPConstans.h as enum values. ================ Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3294 + assert(ExecModeVal & 0x1 && + "Initially non-SPMD kernel has SPMD exec mode!"); + ExecMode->setInitializer(ConstantInt::get( ---------------- Same here. ================ Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:78 + GENERIC = 0x1, // everything else }; ---------------- I think you can include OpenMPConstants.h here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits