jdoerfert added a comment. Just more style things, I think the rest is fine.
================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:134 + SPMD = 0x2, +}; + ---------------- If you copy the LLVM_MARK_AS_BITMASK_ENUM stuff you can actually use the enum class as bitmask w/o the static casts all the time. I'd also suggest to create the combinations here, so GenericSPMD = Generic | SPMD;. ================ Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:863 // default value GENERIC (in case symbol is missing from cubin file) - int8_t ExecModeVal = ExecutionModeType::GENERIC; + int8_t ExecModeVal = 1; std::string ExecModeNameStr(E->name); ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits