Anastasia added a comment. In D110618#3039275 <https://reviews.llvm.org/D110618#3039275>, @linjamaki wrote:
> In D110618#3032899 <https://reviews.llvm.org/D110618#3032899>, @Anastasia > wrote: > >> Considering that SPIR-V translation step is also required for other >> languages would it make sense to add `llvm-spirv` as a common tool like for >> example C/C++ linkers and create a bit of common infrastructure? It might be >> something we can do as a separate step too but it would be good to make sure >> nothing prevents us from doing this in the future... We should probably also >> think about the command line interface unification as it probably doesn't >> make sense for every language to add their own flags for locating SPIR-V >> translator. > > I don’t think it would work out well. llvm-spirv (or other tool relying on > LLVM bitcode input) and LLVM may have version differences that cause obscure > error cases - like newer LLVM producing bitcode with new features the tools > are not expecting and ready for them. The usage of llvm-spirv tool in the > HIPSPV tool chain is not intended to be a longer term solution due to this > shortcoming. I don't feel it is different for OpenCL though... I am not in favour of repeating the same functionality for every language since the requirement will be likely identical. There is no timeline for when this functionality will be dropped so we have to assume that even though temporary it might be a solution for long enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
