asb added a comment. Herald added a reviewer: luke957. From an initial look, I think this is almost ready to land - thank you.
One suggestion would be to review the various `Subtarget.hasStdExtZfhmin() || Subtarget.hasStdExtZfh()`. I'd first thought adding a new helper to RISCVSubtarget to be called instead, but actually it looks like a number of these could be replaced by just hasStdExtZfhmin due to Zfhmin implying Zfh. ================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td:187 } -} // Predicates = [HasStdExtZfh] +} ---------------- Unintended change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
