asb added inline comments. Herald added a subscriber: luke957.
================ Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1153 bool ForCodeSize) const { - if (VT == MVT::f16 && !Subtarget.hasStdExtZfh()) + if (VT == MVT::f16 && !Subtarget.hasStdExtZfhmin() && + !Subtarget.hasStdExtZfh()) ---------------- This could equivalently just be ` if (VT == MVT::f16 && !Subtarget.hasStdExtZfhmin())`, right? ================ Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1177 + if (VT == MVT::f16 && Subtarget.hasStdExtF() && + !Subtarget.hasStdExtZfhmin() && !Subtarget.hasStdExtZfh()) return MVT::f32; ---------------- This could just be `!Subtarget.hasStdExtZfhmin()`? ================ Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1189 + if (VT == MVT::f16 && Subtarget.hasStdExtF() && + !Subtarget.hasStdExtZfhmin() && !Subtarget.hasStdExtZfh()) return 1; ---------------- This could just be `Subtarget.hasStdExtZfhmin()`? ================ Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1396 case MVT::f16: - if (!Subtarget.hasStdExtZfh()) + if (!Subtarget.hasStdExtZfhmin() && !Subtarget.hasStdExtZfh()) return false; ---------------- This could just be `!Subtarget.hasStdExtZfhmin()`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits