jhenderson added inline comments.
================ Comment at: clang/docs/UsersManual.rst:3546 - cmake -G"Visual Studio 15 2017" -T LLVM .. + cmake -G"Visual Studio 16 2019" -T LLVM .. ---------------- Maybe make this VS2022 instead, to help it last longer? ================ Comment at: llvm/docs/GettingStarted.rst:276 do. Windows does not have a "system compiler", so you must install either Visual -Studio 2017 or a recent version of mingw64. FreeBSD 10.0 and newer have a modern +Studio 2019 or a recent version of mingw64. FreeBSD 10.0 and newer have a modern Clang as the system compiler. ---------------- Perhaps add "or Visual Studio 2022" or similar? ================ Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not MSVC 2017. ---------------- Does this comment need changing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
