RKSimon added a comment. > Have you checked whether there are any bots in the lab that will need to be > updated?
I did find a number of bots that I think need addressing, I am intending to privately email the owners but I haven't done that yet - @rnk maintains the sanitizer-windows and windows-gcebot2 machines, but there are others. ================ Comment at: clang/docs/UsersManual.rst:3546 - cmake -G"Visual Studio 15 2017" -T LLVM .. + cmake -G"Visual Studio 17 2022" -T LLVM .. ---------------- aaron.ballman wrote: > jhenderson wrote: > > I think the missing space should be fixed to :) > +1 to the missing space. This one is confusing - it isn't in my local diff, the raw diff, or if I reapply the raw diff - it looks to have just appeared when you quote it in phab comments? ================ Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:17-18 +# _MSC_VER == 1929 MSVC++ 14.29 Visual Studio 2019 Version 16.10 & 16.11 +set(MSVC_MIN 19.20) +set(MSVC_SOFT_ERROR 19.29) ---------------- aaron.ballman wrote: > I'm a bit less certain that this is reasonable. 16.11.0 is from August 2021, > which seems incredibly new for giving soft errors on. Our docs do say the latest update of the compiler, but I take your point. 16.10 (same _MSC_VER) was released in May 2021 https://docs.microsoft.com/en-us/visualstudio/install/visual-studio-build-numbers-and-release-dates?view=vs-2019 If we want something a year old, 16.8 + 16.9 (1928) is about right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
