tianshilei1992 added inline comments.
================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:231
+
+compileDeviceRTLLibrary(x86_64 vgpu -target x86_64-vgpu -std=c++20
-stdlib=libc++ -I${devicertl_base_directory}/../plugins/vgpu/src)
----------------
It's not a good practice to specify include directories in CMake in this way.
Use `include_directories` instead.
================
Comment at: openmp/libomptarget/DeviceRTL/src/Kernel.cpp:127
+#pragma omp begin declare variant match(
\
+ device = {kind(cpu)}, implementation = {extension(match_any)})
----------------
Are these code here unintentional? We don't need to specialize this function
for vgpu IIRC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113359/new/
https://reviews.llvm.org/D113359
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
