bnbarham marked 5 inline comments as done. bnbarham added inline comments.
================ Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:575 +/// instead> +/// 'redirecting-with': <string, one of 'fallthrough', 'fallback', or +/// 'redirect-only', default='fallthrough'> ---------------- keith wrote: > bnbarham wrote: > > keith wrote: > > > I think `redirecting-with` is fine, and I can't come up with something > > > better > > Thanks. Do you know if this format is documented anywhere that I would need > > to update? > Folks here used to joke that the source was the documentation, and based on a > quick search that still seems to be the case, I don't see any places where > the others are mentioned Not sure if I should be happy that I don't need to update anything or sad that this is the case 😆 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117937/new/ https://reviews.llvm.org/D117937 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits