JonasToth added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:33 LINK_LIBS + clangAnalysis clangTidy ---------------- njames93 wrote: > Will this work under clangd as I don't think that links in the clangAnalysis > libraries @sammccall? I did not check if it works and `clangd` does not explicitly link to `Analysis`, but only to the checks. Doesn't the `LINK_LIBS` induce transitive dependency resolution for linking? ================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:102-105 + // There have been crashes on 'Variable == nullptr', even though the matcher + // is not conditional. This comes probably from 'findAll'-matching. + if (!Variable || !LocalScope) + return; ---------------- njames93 wrote: > This sounds like a bug that should be raised with ASTMatchers, if its > reproducible. I found no way to reproduce it (yet). The crashes occured during verification on big projects and `run-clang-tidy` kind of obfuscated where the crash happened. This is something for the iron out part of the check I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
