njames93 added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:102-105 + // There have been crashes on 'Variable == nullptr', even though the matcher + // is not conditional. This comes probably from 'findAll'-matching. + if (!Variable || !LocalScope) + return; ---------------- sammccall wrote: > JonasToth wrote: > > njames93 wrote: > > > This sounds like a bug that should be raised with ASTMatchers, if its > > > reproducible. > > I found no way to reproduce it (yet). > > The crashes occured during verification on big projects and > > `run-clang-tidy` kind of obfuscated where the crash happened. > > > > This is something for the iron out part of the check I think. > This is a bug in a helper added in this patch, I've added a comment above. Ahh, hopefully once D118520 lands it should be easier to track down these bugs and create reproducers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
