jdoerfert added inline comments.
================ Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; + }; + ---------------- You can use AAPointerInfo for the call site return IRPosition. It will (through the iterations) gather all accesses and put them into "bins" based on offset and size. It deals with uses in calls, etc. and if there is stuff missing it is better to add it in one place so we benefit throughout. ================ Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:589 + A.checkForAllCallLikeInstructions(CheckForHostcallAccess, *this, + UsedAssumedInformation); + ---------------- Always check the return value, if it is false something went wrong and some calls might have been missed. Basically, ``` if (!A.check...) NeedsHostCallPtr = true; ``` then you also can just return false in the callback w/o setting it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119216/new/ https://reviews.llvm.org/D119216 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
