arsenm added inline comments.
================ Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:198 + const auto *STI = TM.getMCSubtargetInfo(); + return llvm::AMDGPU::getHostcallImplicitArgPosition(STI); + } ---------------- The ABI should not be a property of the subtarget, and the global subtarget shouldn't be used ================ Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-hostcall-v5.ll:55 + +; Typical load of hostcall buffer pointer + ---------------- Can you also add cases where the load is wider and the hostcall pointer is a subset of it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119216/new/ https://reviews.llvm.org/D119216 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
