owenpan accepted this revision.
owenpan added inline comments.

================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:578
+        break;
+
       LLVM_FALLTHROUGH;
----------------
Can we remove this empty line?


================
Comment at: clang/lib/Format/UnwrappedLineParser.h:125-126
   FormatToken *parseIfThenElse(IfStmtKind *IfKind, bool KeepBraces = false);
+  void handleAttributes();
+  bool handleCppAttributes();
   void parseTryCatch();
----------------
Can we move them 1 line up so that the order of the declarations here will be 
the same as that of the definitions in the .cpp file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121450/new/

https://reviews.llvm.org/D121450

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to