jgorbe added a comment.

Hi,

We've observed that this patch introduces infinite loops in some cases. Here's 
a reduced test case:

  export class Foo extends Bar {
    get case(): Case {
      return (
          (this.Bar$has('case')) ? (this.Bar$get('case')) :
                                   (this.case = new Case()));
    }
  }

Saving this as `/tmp/test.ts` and running `clang-format /tmp/test.ts` loops 
indefinitely with this patch (I stopped it after 1m27s) and finishes instantly 
(0.12s) after reverting the patch locally. I'm going to go ahead and push a 
revert. Please let me know if you need help reproducing the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121450/new/

https://reviews.llvm.org/D121450

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to