urnathan added a comment. In D122119#3398823 <https://reviews.llvm.org/D122119#3398823>, @iains wrote:
> > With the change here we now get: > cannot export redeclaration 'f' here since the previous declaration has > internal linkage > cannot export redeclaration 'S' here since the previous declaration has > module linkage > > which seems maybe to be more helpful to the user in telling them why. > > I hope others can weigh in with an opinion here .. @dblaikie @vsapsai ? Yes, this is more helpful -- tell the user what the compiler thinks it is, rather than what it thinks it is not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122119/new/ https://reviews.llvm.org/D122119 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
