sammccall accepted this revision. sammccall added inline comments.
================ Comment at: clang/include/clang/Basic/LangStandard.h:141 static Kind getLangKind(StringRef Name); + static Kind getLangKind(clang::Language Lang, const llvm::Triple &T); + ---------------- this makes it sound like a simple getter/lookup, which it absolutely is not! `getDefaultLanguageStandard`? And separate it out from the simple getters? (The meaningless distinction in the other function names between "standard" and "kind", and the "lang" abbreviation are both pretty unfortunate here, we don't need to fix them but let's not propagate them further) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121375/new/ https://reviews.llvm.org/D121375 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
