tra added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6836 + + // If the CUID is not specified we try to generate a unique postfix. + if (getLangOpts().CUID.empty()) { ---------------- > However, [CUID] is not always availible. The question is -- when and why is it not available? I'm getting the feeling that we're fixing the consequence here, not the root cause. Is there a reason we can't make sure that the driver always generates a cuid for offload subcompilations and error out if it's needed but is not provided? That would make this fallback unnecessary and would be a more robust approach in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125904/new/ https://reviews.llvm.org/D125904 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits