jhuber6 added a comment.

Also, for the OpenMP case, we already pass the host-IR as a dependency for the 
device compilation. So it would be relatively easy for us to just generate 
these names on the host and then read them from the IR for the device. The 
problem is that CUDA / HIP doesn't use this approach so it wouldn't be a great 
solution to have two different ways to do this. So we would either need to make 
CUDA / HIP take the host IR and use that, or move OpenMP to use the driver. The 
benefit of passing the IR is that we can much more stably generate some 
arbitrary string to mangle these names and we're guarunteed to have them match 
up because we read them from the host. The downside is that it'd be somewhat of 
a regression because now we have an extra call to Clang for CUDA / HIP when we 
previously didn't need to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125904/new/

https://reviews.llvm.org/D125904

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to