awarzynski added a comment. 🤔 linker-flags.f90 is failing on Windows in the pre-commit CI. Not sure why - seems fine on Debian.
================ Comment at: flang/test/Driver/linker-flags.f90:28 +! GNU-SAME: -lFortranDecimal +! WITHLM-SAME: -lm + ---------------- Does `-SAME` makese sense here? As in, this makes sense to me: ``` ! GNU: -lFortranDecimal ! GNU-SAME: -lm ``` and this: ``` ! WITHLM: -lFortranDecimal ! WITHLM-SAME: -lm ``` but for `! WITHLM-SAME: -lm` there's no [[ https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-same-directive | previous match ]], is there? ================ Comment at: flang/test/Driver/linker-flags.f90:33-34 +! MSVC-LABEL: link.exe +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: Fortran_main.lib ---------------- Is it worth adding a comment to explain why to single these out? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
