awarzynski added inline comments.
================ Comment at: flang/test/Driver/linker-flags.f90:51 +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: "[[object_file]]" ---------------- rovka wrote: > mmuetzel wrote: > > Lines 50-51 seem to be duplicates of lines 44-45. Is this intentional? > Yes, I don't want those to appear either before or after the Fortran libs. I > guess if we wanted to be pedantic we'd also check that they don't appear > after the object_file, or between the libs and the subsystem, but that seems > a bit much. Based on the [[ https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-same-directive | docs ]], I'd say that this would be the idiomatic way to do this: ```lang=bash ! MSVC-LABEL: ! MSVC-NOT: ! MSVC-SAME: ``` IIUC, the following would only be needed if there's a potential for `libcmt` or `oldnames` to appear on a separate line: ``` ```lang=bash ! MSVC-LABEL: ! MSVC-NOT: ! MSVC-SAME: ! MSVC-NOT: ``` But this wouldn't happen, right? (there's going to be only one linker invocation). Also, you could just use [[ https://llvm.org/docs/CommandGuide/FileCheck.html#options | --implicit-check-not ]] :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits