awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land.
LGTM, many thanks for this non trivial effort! :) I've left a few nits, feel free to ignore! @mstorsjo , are you also OK with this change? [nit] "This is exactly what we do for Linux/Darwin, but the interface is slightly different (e.g. -libpath instead of -L)." -> Perhaps clarify what "interface" you have in mind (e.g. "Windows interface"). ================ Comment at: flang/test/Driver/linker-flags.f90:12 -!------------ -! RUN COMMAND -!------------ -! Use `--ld-path` so that the linker location (used in the LABEL below) is deterministic. -! RUN: %flang -### -flang-experimental-exec --ld-path=/usr/bin/ld %S/Inputs/hello.f90 2>&1 | FileCheck %s +! NOTE: Clang usually adds 'libcmt' and 'oldnames' on Windows, but +! they are not needed when compiling Fortran code and they might ---------------- This is a nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
