mizvekov added a comment.

In D129222#3667638 <https://reviews.llvm.org/D129222#3667638>, @hokein wrote:

> Yeah,  the native clang-pseudo-gen tool didn't rebuild somehow even its 
> source file changes, it is a bug in our cmake config. Should be fixed in 
> 2955192df8ac270515b5fa4aaa9e9380148e7f00 
> <https://reviews.llvm.org/rG2955192df8ac270515b5fa4aaa9e9380148e7f00> (I 
> verified it locally). Can you retry it with `LLVM_OPTIMIZED_TABLEGEN` on?

Yeah I confirm that fixes it, thanks!

Though it's strange that you would have to declare that dependency explicitly, 
I think it should be implied.

One other small thing I noticed: It seems the pseudo-gen tool generated output 
takes care of undefining the macros it takes as input to expand, but we don't 
take advantage of that fact on 
`clang-tools-extra\pseudo\include\clang-pseudo\cxx\CXX.h` and are always 
undefing them. Just a minor thing :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129222/new/

https://reviews.llvm.org/D129222

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to