mizvekov added a comment. In D129222#3668158 <https://reviews.llvm.org/D129222#3668158>, @sammccall wrote:
> I think what's going on here: outer cmake invokes this opaque external > command (which just _happens_ to be cmake --build) to produce an exe. The > outer cmake has no special knowledge of what the inner cmake is going to use > as inputs, so i it never invalidates the exe and invokes inner cmake again. > Having the native exe depend on the target exe is a hack: it means that it > (indirectly) depends on the right set of sources and is invalidated when they > change. (In a perfect world we wouldn't build the target clang-pseudo-gen at > all) Yeah I agree, I just meant that `build_native_tool` (From https://reviews.llvm.org/rG2955192df8ac270515b5fa4aaa9e9380148e7f00) might as well just always add this dependency itself. I think that anything that uses it and forgets to add this dependency would be a bug anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/ https://reviews.llvm.org/D129222 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
