shafik added a comment. In D129973#3673094 <https://reviews.llvm.org/D129973#3673094>, @SimplyDanny wrote:
> Thank you for the review! Before I push the change into main I may add an > entry to `clang/docs/ReleaseNotes.rst`, right? Yes, please add an entry in the release notes. > And do you agree that the test failures are unrelated to my change? It looks > like they are all located in `libomptarget` caused by a linker error. They don't look related but as always you should be ready to revert if any of the builds break in a way that you can't fix quickly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits