yvvan added a comment.

In D129973#3688329 <https://reviews.llvm.org/D129973#3688329>, @SimplyDanny 
wrote:

> In D129973#3684940 <https://reviews.llvm.org/D129973#3684940>, @yvvan wrote:
>
>> With this change we don't pass "LocInfo" directly and it seems to break the 
>> locations when calling "getCXXOperatorNameRange" for this DeclRefExpr later 
>> on. Please fix it. You can introduce another "Create" static method for 
>> DeclRefExpr that accepts LocInfo and passes it to the DeclarationNameInfo 
>> constructor.
>
> Thank you for the hint! This indeed "fixes" the test references so that they 
> can be reverted to their original state. This is done in D130799 
> <https://reviews.llvm.org/D130799>.
>
> Instead of a new `create` method or a new constructor (there are already 
> quite a lot of them with complex signatures), I created a 
> `DeclarationNameInfo` and passed it to one of the existing creators.

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129973/new/

https://reviews.llvm.org/D129973

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to