aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
I'm okay with this approach, but please be sure to add a release note explaining the behavior and update AttrDocs.td as well, so that users have some notice as to what's broken. ================ Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2925-2926 for (unsigned I = 0, E = readInt(); I != E; ++I) - Attrs.push_back(readAttr()); + if (auto *Attr = readAttr()) + Attrs.push_back(Attr); } ---------------- Some IDEs do poorly when a variable has the same name as a type (for things like jump to definition, etc). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130331/new/ https://reviews.llvm.org/D130331 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
