shraiysh added a comment.
Minor comments. Thank you for working on this!
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625
+ void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen,
+ ConstantInt *Safelen);
----------------
[nit] Please set the default value of Safelen to nullptr here.
================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1808
+ ConstantInt::get(Type::getInt32Ty(Ctx), 3),
+ /* Safelen */ nullptr);
----------------
[nit] remove this change after setting default value.
================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1920
+ OMPBuilder.applySimd(CLI, IfCmp, ConstantInt::get(Type::getInt32Ty(Ctx), 3),
+ /* Safelen */ nullptr);
----------------
[nit] same as above
================
Comment at:
mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:976
loop.if_expr() ? moduleTranslation.lookupValue(loop.if_expr()) : nullptr,
- simdlen);
+ simdlen, nullptr);
----------------
[nit] same as above
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131526/new/
https://reviews.llvm.org/D131526
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
