shraiysh added inline comments.
================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen); ---------------- psoni2628 wrote: > shraiysh wrote: > > [nit] Please set the default value of Safelen to nullptr here. > Setting a default value for only `Safelen` but not `Simdlen` or `IfCond` is a > bit inconsistent and could potentially cause confusion in the future. I think > it would make more sense to set default values for all the clause values. > Maybe we could this separately in a different patch? Sounds good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
