mizvekov marked 3 inline comments as done. mizvekov added a comment. In D111283#3721905 <https://reviews.llvm.org/D111283#3721905>, @davrec wrote:
> But instead of defining it and getting into details it might be clearer, and > certainly would have saved me the most time, for the description to simply > note that this patch introduces `ASTContext::getCommonSugaredType(QualType X, > QualType Y, bool Unqualified = false)`, and puts it to use in type deduction > for binary expressions etc., and give an example or two to demonstrate. > (More generally on a large patch I prefer a description to give me a few > starting points, the primary changes which necessitate all the others.) Done, thanks for the feedback! > Re the patch itself: it looks good to me other than a few nits, but this has > such a broad and deep span (intricate details of the AST + intricate details > of Sema) it is difficult to give it a final thumbs up - really hoping @rsmith > might take a final look. But if time runs out it is definitely worth > accepting as is and seeing how it goes; the benefits exceed the risks. I > will try to take a close look at the other patches on your stack, but the > same probably applies. You've done a tremendous amount of work here, very > impressive. Yeah, but we made good progress here, thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
