asb requested changes to this revision. asb added a comment. This revision now requires changes to proceed.
Everything that's in this patch looks good to me - it's just missing some simple round-trip tests in the style of rv32zicboz-valid.s (and perhaps an -invalid.s that shows a sensible error message being produced when the instructions have an argument). In terms of which *.td file to edit - RISCVInstrInfoA.td is another possibility. The plan had been that for the `z?foo` extensions, the letter after the z indicated which of the top-level extensions it was most relevant to - e.g. the zc* extensions (ztso predated this idea). I don't mind much either way - I'm happy with it in either location. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133443/new/ https://reviews.llvm.org/D133443 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
