hubert.reinterpretcast added a comment. In D128745#3833291 <https://reviews.llvm.org/D128745#3833291>, @aaron.ballman wrote:
> @rjmccall is correct about us not being required to apply DRs when they're > disruptive, but at the same time, WG21 DRs are intended to be handled as if > the original standard they were reported against had always been using the > fixed form. So *not* applying a DR in order to avoid problems for existing > code can cause problems for existing and future code in terms of portability > between compilers (and ABI impacts that stem from the semantic changes). So I > think we wish to apply the DRs as broadly as we can. The question is: do we > think users with existing code should not have to change or do we think it's > reasonable to give them a flag to opt into the old behavior? My personal > feeling is -- the default compiler mode should be as conforming as we can > make it be within reason, and since this has some impact but not a massive > break (no major OS SDKs or third party libraries seem to be impacted as best > I can tell), my feeling is that we should strongly consider adding a feature > flag (other than ABI compat, as that does seem like a bit of an odd choice to > key on) to opt into the older behavior, esp since the break is a loud one and > not a silent one. > > Adding @hubert.reinterpretcast as C++ conformance code owner in case he's got > opinions as well. I happen to be on vacation this week ahead of Canadian Thanksgiving (or trying as much as I can anyway). I agree that broad application of DRs is generally what has been expected in the context of Clang and GCC (except where it is believed the DR resolution itself is defective, in which case the committee is consulted). It seems there is a question of whether the DR resolutions are defective/too breaking to be advisable. Do we have a useful summary of what led to that opinion? In considering a compatibility flag, I think some thought should be given to whether to time-limit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
