awarzynski added a comment. In D129156#3847396 <https://reviews.llvm.org/D129156#3847396>, @tarunprabhu wrote:
> Added `examples` to `REQUIRES` in `test/Driver/pass-plugin.f90. Thanks for the update! > I still cannot reproduce the build failure on my end. @MatsPetersson tested > this patch and the tests passed. @MatsPetersson & @clementval , could you share you build command so that the failure can be reproduced before this re-lands? > Could someone else test this on their build and let me know if it works - > especially if the previous version failed for you. I can try as soon as folks share their build commands. In general, I'm concerned that this fix is not enough. It merely makes sure that "pass-plugin.f90" is only run when `LLVM_BUILD_EXAMPLES` is set (or whatever other flag that sets `examples` in LIT). However, that's not sufficient to make sure that `libBye.so` is built when running `ninja check-flang`. I might wrong though - have you checked this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
