zaks.anna added inline comments.

================
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics 
does not support diagnostics that cross file boundaries.
----------------
We should use the name of the diagnostic consumer here - that will only be 
legible for the developers working on the attic analyzer core. 

================
Comment at: test/Analysis/PR12421.h:1
@@ +1,2 @@
+static void f() {
+  int *p = 0;
----------------
Please. do not use the PR as a file name. Use the purpose of the test instead,


https://reviews.llvm.org/D22494



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to