zaks.anna added inline comments. ================ Comment at: test/Analysis/PR12421.c:11 @@ +10,2 @@ + +// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics does not support diagnostics that cross file boundaries. ---------------- ayartsev wrote: > zaks.anna wrote: > > We should use the name of the diagnostic consumer here - that will only be > > legible for the developers working on the attic analyzer core. > Done. As for me the name of the diagnostic consumer also makes the warning > more clear and helpful for an ordinary user. From the consumer name he can > see what report format is talked about and maybe change the scan-build (which > setups the '-analyzer-output' frontend option internally) options. Do you > still want to remove the consumer name from the warning? "HTMLDiagnostics" is not a name a user would be familiar with. You should use only familiar terms in diagnostics.
================ Comment at: test/Analysis/PR12421.h:1 @@ +1,2 @@ +static void f() { + int *p = 0; ---------------- zaks.anna wrote: > Please. do not use the PR as a file name. Use the purpose of the test instead, this does not seem to be done. https://reviews.llvm.org/D22494 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits