RKSimon added inline comments.
================ Comment at: clang/test/CodeGen/X86/cmpccxadd-builtins-error.c:2 +// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown \ +// RUN: -target-feature +cmpccxadd -emit-llvm -fsyntax-only -verify + ---------------- Add 32-bit test coverage to ensure the intrinsics aren't visible? ================ Comment at: llvm/CMakeLists.txt:887 + list(APPEND features_enabled_by_default + ${LLVM_INTELFEATURE_PREFIX}_ISA_CMPCCXADD) ---------------- What is this for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135933/new/ https://reviews.llvm.org/D135933 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits