craig.topper added inline comments.
================ Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:1071 return 1; // Check for AVX-512 scatter which has a TIED_TO in the second to last // operand. ---------------- craig.topper wrote: > This comment is out of date. I'd prefer if you fixed the comment rather than deleting it. ================ Comment at: llvm/lib/Target/X86/X86InstrInfo.td:3027 +def CMPCCXADDmr32 : I<0xe0, MRMDestMem4VOp3CC, (outs GR32:$dst), + (ins i32mem:$dstsrc1, GR32:$dstsrc2, GR32:$src3, ccode:$cond), + "cmp${cond}xadd\t{$src3, $dst, $dstsrc1|$dstsrc1, $dst, $src3}", ---------------- Can we put $dstsrc2 before $dstsrc1 in the ins list? That would remove the need for the change in `getOperandBias` I think. But maybe it complicates the encoder and disassembler? ================ Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8125 } - ---------------- Looks like there's a blank line being deleted here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135933/new/ https://reviews.llvm.org/D135933 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits