FreddyYe marked 2 inline comments as done. FreddyYe added a comment. In D135938#3864521 <https://reviews.llvm.org/D135938#3864521>, @RKSimon wrote:
> Can you fix the MC + disasm test file names - drop att/intel and ensure you > test both syntaxes for 32 and 64 bits. > > Ideally the 32/64 bit names should be close to each other in a file list > (e.g. avx-vnni-int8-32.s + avx-vnni-int8-64.s ?) I get your point of "close to each other" and updated. And I merged the Disasm tests, while I didn't merge the MC tests because it is not so convenient to do. See latest updated. Do we need to rename old tests to follow this rule? Old tests: https://github.com/llvm/llvm-project/tree/main/llvm/test/MC/X86 and https://github.com/llvm/llvm-project/tree/main/llvm/test/MC/Disassembler/X86 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
