MaskRay added inline comments.
================
Comment at: clang/test/Driver/AS_SECURE_LOG_FILE.s:1
+// RUN: env AS_SECURE_LOG_FILE=%t %clang -target x86_64-apple-darwin -c %s -o
%t.o -### 2>&1 | FileCheck %s -DLOG_FILE=%t
+// CHECK: "-cc1as"
----------------
`--target=` for new tests
remove unused `-o %t.o`
================
Comment at: llvm/lib/MC/MCContext.cpp:77
AutoReset(DoAutoReset), TargetOptions(TargetOpts) {
- SecureLogFile = AsSecureLogFileName;
+ SecureLogFile = TargetOptions ? TargetOptions->AsSecureLogFile : "";
----------------
When is TargetOptions null? When it is TargetOptions, Does a value of `""`
matter?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136888/new/
https://reviews.llvm.org/D136888
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
