benlangmuir added inline comments.
================ Comment at: llvm/lib/MC/MCContext.cpp:77 AutoReset(DoAutoReset), TargetOptions(TargetOpts) { - SecureLogFile = AsSecureLogFileName; + SecureLogFile = TargetOptions ? TargetOptions->AsSecureLogFile : ""; ---------------- MaskRay wrote: > When is TargetOptions null? When it is TargetOptions, Does a value of `""` > matter? > When is TargetOptions null? null is the default value for the parameter, and happens in various places that construct MCOptions. None of them require a secure log file as far as I can tell. > Does a value of "" matter? Like the other file path in MCTargetOptions (SplitDwarfFile) empty indicates no file specified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136888/new/ https://reviews.llvm.org/D136888 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits