omtcyfz added a comment. Apart from my high level concerns, which of course I still have...
================ Comment at: clang-rename/tool/clang-rename.py:43 @@ -42,2 +42,3 @@ command = [binary, + "rename-at", filename, ---------------- `rename-at` isn't necessary here anymore since it's going to be default behavior IIUC ================ Comment at: docs/clang-rename.rst:35 @@ -34,3 +34,3 @@ - $ clang-rename -offset=42 -new-name=foo test.cpp -- -Imy_project/include -DMY_DEFINES ... + $ clang-rename rename-at -offset=42 -new-name=foo test.cpp -- -Imy_project/include -DMY_DEFINES ... ---------------- docs should be fixed correspondingly; i.e. prefer to write `clang-rename -offset=42....` over `clang-rename -rename-at` ================ Comment at: docs/clang-rename.rst:50 @@ +49,3 @@ + + $ clang-rename rename-all -old-name=foo -new-name=bar test.cpp + ---------------- here and later, too https://reviews.llvm.org/D21814 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits