pmatos marked 5 inline comments as done.
pmatos added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2171-2176
def err_reference_bind_to_vector_element : Error<
"%select{non-const|volatile}0 reference cannot bind to vector element">;
def err_reference_bind_to_matrix_element : Error<
"%select{non-const|volatile}0 reference cannot bind to matrix element">;
+def err_reference_bind_to_table_element : Error<
+ "%select{non-const|volatile}0 reference cannot bind to table element">;
----------------
aaron.ballman wrote:
> We should combine these diagnostics with a `%select` rather than keep
> duplicating the same message.
>
> This is unused and untested.
Right - this is no longer needed.
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3035-3040
def err_attribute_invalid_vector_type : Error<"invalid vector element type
%0">;
def err_attribute_invalid_bitint_vector_type : Error<
"'_BitInt' vector element width must be %select{a power of 2|"
"at least as wide as 'CHAR_BIT'}0">;
def err_attribute_invalid_matrix_type : Error<"invalid matrix element type
%0">;
+def err_attribute_invalid_wasm_table_type : Error<"invalid table element type
%0">;
----------------
aaron.ballman wrote:
> We should probably combine these as well.
>
> This is unused and untested.
Sigh - again. Apologies. This was an initial patch that used matrix subscript
to create a table subscript patch but was dropped and therefore is unused.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139010/new/
https://reviews.llvm.org/D139010
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
