asb added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11827 +def err_wasm_builtin_arg_must_be_integer_type : Error < + "%ordinal0 argument must be an integer">; } // end of sema component. ---------------- aaron.ballman wrote: > I'm a bit shocked by the number of new diagnostics for this type as it seems > incredibly restrictive and like the rules are going to be hard to understand. > For example, you cannot use this type in an exception specification despite > that being a compile-time property. Can you use it within a conditional > explicit clause (https://godbolt.org/z/sn3G8xE3T)? It must be static, but can > it be thread local? > > Basically, it seems like this type is unlike basically any other type and > we're going to have to carry a significant amount of extra code around to > handle all the edge cases and those edge cases look a bit like whack-a-mole > in practice. The whack-a-mole aspect of disallowing table uses is something I'm not fond of either....but I'm not sure I see a better approach. Do you have any alternatives in mind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
