jroelofs added a subscriber: jroelofs.
jroelofs added a comment.

I think the replacement is wrong for something like:

  int *arr; int offs1, offs2;
  offs1[arr + offs2] = 42;

which I think would give:

  int *arr; int offs1, offs2;
  arr + offs2[offs1] = 42;

If the precedence of the "indexing" argument is less than that of the subscript 
operator, then you need to insert parens:

  int *arr; int offs1, offs2;
  (arr + offs2)[offs1] = 42;


https://reviews.llvm.org/D21134



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to