kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks! ================ Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, <experimental/filesystem>) ---------------- zyounan wrote: > kadircet wrote: > > zyounan wrote: > > > kadircet wrote: > > > > can you strip clang-format pragmas to be similar to other mapping files. > > > I'd love to if possible, but for some reason clang-format would add extra > > > spaces before and after the slash, `<experimental / filesystem>`, which > > > looks ugly and I don't expect it right. > > i don't follow, why do you **need** to run clang-format on this file? > > symbols are already ordered > Specifically, it is `git clang-format`. The pipeline would fail if this > command does modify some files IIRC. not sure what workflow you're using but clang-format is not a mandatory part of the workflow. recommended way is updating/uploading patches using arcanist, whose config only contains files with one of the `cc|h|cpp` extensions, see https://github.com/llvm/llvm-project/blob/main/.arclint. anyways, happy to land this for you if it's not easy to disable clang-format linting on your workflow for whatever reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
