kadircet added a comment. Thanks for updating this, as I mentioned in https://reviews.llvm.org/D143319#4115186, we should put these symbols into their own symbol map. ATM `StdSymbolMap.inc` is still generated by an automated tool and shouldn't be modified by hand. So can you rather put these symbols into `llvm/llvm-project/clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc` ? you also need to rebase your branch, we've moved these mappings from `include` directory to `lib`. they're implementation details now, and not public interfaces. After putting it into a new file, you'll also need to include it in https://github.com/llvm/llvm-project/blob/main/clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp#L65.
As for tests, rather than using clangd, can you introduce tests into StandardLibrary instead in https://github.com/llvm/llvm-project/blob/main/clang/unittests/Tooling/StandardLibraryTest.cpp ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
