agozillon added a comment.

The recent update removed the added offload related code from Flang.h/.cpp and 
removed the related test.

Would it be possible to have an extra sign-off as requested by @awarzynski (or 
more review points to correct/discuss if we aren't happy with the 
state/direction of the patch) from either @kiranchandramohan or @jdoerfert my 
apologies for the pings!

And then provided @awarzynski is happy with the current state of the patch 
after this recent commit and no further comments I can commit and close the 
patch :)

Thank you very much for all the excellent comments in this review, and the 
attention given to it, I appreciate it greatly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144864/new/

https://reviews.llvm.org/D144864

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to