kiranchandramohan accepted this revision. kiranchandramohan added a comment.
LG. See one minor comment in the tests. I would prefer having an Interface for Target Modules if that could be made to work. I guess this can be taken up separately after https://reviews.llvm.org/D144883. ================ Comment at: flang/test/Lower/OpenMP/omp-is-device.f90:8-17 +!DEVICE: module attributes {{{.*}}, omp.is_device = true{{.*}}} +!HOST: module attributes {{{.*}}, omp.is_device = false{{.*}}} +!DEVICE-FLAG-ONLY: module attributes {{{.*}}" +!DEVICE-FLAG-ONLY-NOT: , omp.is_device = {{.*}} +!DEVICE-FLAG-ONLY-SAME: } +!BBC-DEVICE: module attributes {{{.*}}, omp.is_device = true{{.*}}} +!BBC-HOST: module attributes {{{.*}}, omp.is_device = false{{.*}}} ---------------- Any reason to have separate checks for essentially the same (e.g: DEVICE vs BBC-DEVICE)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
